Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)

[Paul Brook <paul@codesourcery.com>]

On Thursday 22 May 2008, Anthony Liguori wrote:
> Paul Brook wrote:
> >> +# Check if any targets require dyngen
> >> +for target in $target_list; do
> >
> > You've just duplicated this logic. Please don't.
>
> The problem is the dyngen checks have to be done before the use of $cc
> which is long before the target_list loop.  In the absence of
> introducing functions in the configure script (which aren't there right
> now), I don't see a good way to avoid the duplication.
>
> The duplication is small and it's temporary until all targets convert to
> TCG

TBH I'd rather just finish the TCG conversion and rip out dyngen altogether.

Paul