From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JzDhY-0003SX-9N
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:31:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JzDhV-0003S3-Qu
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:31:34 -0400
Received: from [199.232.76.173] (port=41394 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JzDhV-0003S0-L6
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:31:33 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:56775)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1JzDhV-0006Qc-DC
	for qemu-devel@nongnu.org; Thu, 22 May 2008 12:31:33 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Don't require GCC3 unless necessary (v2)
Date: Thu, 22 May 2008 17:31:28 +0100
References: <1211404888-29146-1-git-send-email-aliguori@us.ibm.com>
	<200805221420.19520.paul@codesourcery.com>
	<48359DE0.9070807@us.ibm.com>
In-Reply-To: <48359DE0.9070807@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805221731.29319.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>

On Thursday 22 May 2008, Anthony Liguori wrote:
> Paul Brook wrote:
> >> +# Check if any targets require dyngen
> >> +for target in $target_list; do
> >
> > You've just duplicated this logic. Please don't.
>
> The problem is the dyngen checks have to be done before the use of $cc
> which is long before the target_list loop.  In the absence of
> introducing functions in the configure script (which aren't there right
> now), I don't see a good way to avoid the duplication.
>
> The duplication is small and it's temporary until all targets convert to
> TCG

TBH I'd rather just finish the TCG conversion and rip out dyngen altogether.

Paul