From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: qemu-devel@nongnu.org
Cc: paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] Fix ATAPI GET_CONFIGURATION function
Date: Sun, 25 May 2008 02:53:19 -0500 [thread overview]
Message-ID: <20080525075319.GA2627@tapir> (raw)
In-Reply-To: <51775D7B-EA5B-471C-A664-ADA734850CB6@suse.de>
On Sat, May 24, 2008 at 12:31:01PM +0200, Alexander Graf wrote:
> Is there anything particularly wrong with this patch?
no, but the SPEC (I used MMC6 r01) says :
6.5.1.4 Allocation Length
The Allocation Length field specifies the maximum length in bytes of the Get
Configuration response data. An Allocation Length field of zero indicates
that no data shall be transferred. This condition shall not be considered an
error.
this is only implicitly supported by truncating the response using max_len
for the ide_atapi_cmd_reply with your patch and so the work of generating the
response is still happening regardless.
> Does it break any guest OSs I am not aware of?
the original implementation (*) broke [Open]Solaris by overflowing the buffer
that was used in the calls to detect the CDROM/DVDROM (using a 8 byte buffer)
Carlo
(*) http://svn.savannah.gnu.org/viewvc/trunk/hw/ide.c?root=qemu&r1=3147&r2=3161
next prev parent reply other threads:[~2008-05-25 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 14:34 [Qemu-devel] [PATCH] Fix ATAPI GET_CONFIGURATION function Alexander Graf
2008-05-24 10:31 ` Alexander Graf
2008-05-24 19:54 ` Alexander Graf
2008-05-25 7:53 ` Carlo Marcelo Arenas Belon [this message]
2008-05-25 9:27 ` Alexander Graf
2008-05-25 10:38 ` Carlo Marcelo Arenas Belon
2008-05-26 8:59 ` Alexander Graf
2008-05-26 17:46 ` Alexander Graf
2008-05-27 18:10 ` Carlo Marcelo Arenas Belon
2008-05-30 1:32 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525075319.GA2627@tapir \
--to=carenas@sajinet.com.pe \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).