From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K11BX-0008Ar-OX for qemu-devel@nongnu.org; Tue, 27 May 2008 11:33:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K11BV-00089w-PI for qemu-devel@nongnu.org; Tue, 27 May 2008 11:33:59 -0400 Received: from [199.232.76.173] (port=42589 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K11BV-00089r-Jq for qemu-devel@nongnu.org; Tue, 27 May 2008 11:33:57 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:56073) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K11BU-0000p4-5D for qemu-devel@nongnu.org; Tue, 27 May 2008 11:33:56 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec Date: Tue, 27 May 2008 16:33:50 +0100 References: <1211901505-30519-1-git-send-email-gcosta@redhat.com> <1211901505-30519-2-git-send-email-gcosta@redhat.com> In-Reply-To: <1211901505-30519-2-git-send-email-gcosta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805271633.51342.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Glauber Costa > +void cpu_load_flags(CPUState *env); > +void cpu_put_flags(CPUState *env); These really need a comment saying what they do. The names are not at all intuitive. Also, why load/put? I'd expect load/save/store or get/put. > +#if defined(reg_REGWPTR) > +static uint32_t *saved_regwptr; > +#endif Eww. You've replaced reasonably self contained local code with a global variable hidden deep in target specific code. I plan on adding multithreaded qemu support soon, so this is a non-starter. Paul