From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K11Dq-0001Eg-RS for qemu-devel@nongnu.org; Tue, 27 May 2008 11:36:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K11Dq-0001EA-29 for qemu-devel@nongnu.org; Tue, 27 May 2008 11:36:22 -0400 Received: from [199.232.76.173] (port=42680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K11Dp-0001E7-Ot for qemu-devel@nongnu.org; Tue, 27 May 2008 11:36:21 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:56123) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K11Dp-0001JC-Li for qemu-devel@nongnu.org; Tue, 27 May 2008 11:36:22 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 5/6] isolate mmu code in arch-specific function Date: Tue, 27 May 2008 16:36:16 +0100 References: <1211901505-30519-1-git-send-email-gcosta@redhat.com> <1211901505-30519-5-git-send-email-gcosta@redhat.com> <1211901505-30519-6-git-send-email-gcosta@redhat.com> In-Reply-To: <1211901505-30519-6-git-send-email-gcosta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805271636.17700.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Glauber Costa On Tuesday 27 May 2008, Glauber Costa wrote: > Simplify cpu_exec by removing a TARGET_I386 block, responsible > for conditionally resetting the mmu, and enclosing it inside > a function. I suspect this doesn't do what you think it does. My suggestion is to remove the !CONFIG_SOFTMMU bits altogether. I expect they're fairly bitrotten. Paul