qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: Paul Brook <paul@codesourcery.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4597] CRIS: Re-add the X flag to the tb flags, it allows for better code generation and is practially always cleared.
Date: Wed, 28 May 2008 14:24:32 +0200	[thread overview]
Message-ID: <20080528122432.GE3968@edgar.se.axis.com> (raw)
In-Reply-To: <200805272330.03117.paul@codesourcery.com>

On Tue, May 27, 2008 at 11:30:02PM +0100, Paul Brook wrote:
> On Tuesday 27 May 2008, Edgar E. Iglesias wrote:
> > Revision: 4597
> >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4597
> > Author:   edgar_igl
> > Date:     2008-05-27 21:15:56 +0000 (Tue, 27 May 2008)
> >
> > Log Message:
> > -----------
> > CRIS: Re-add the X flag to the tb flags, it allows for better code
> > generation and is practially always cleared.
> 
> Are you sure this is safe? It means you shouldn't do TB chaining from any 
> block that modifies the X flag, and I don't see any code for that.

I wouldn't expect the cris translator to handle broken X sequences (it's a TODO). I'll look into it when adding proper X flag support.

Thanks for the hint, I didn't know the target specific code was responsible for assuring flag consistency at tb chaining.

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB

      reply	other threads:[~2008-05-28 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27 21:15 [Qemu-devel] [4597] CRIS: Re-add the X flag to the tb flags, it allows for better code generation and is practially always cleared Edgar E. Iglesias
2008-05-27 22:30 ` Paul Brook
2008-05-28 12:24   ` Edgar E. Iglesias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080528122432.GE3968@edgar.se.axis.com \
    --to=edgar.iglesias@axis.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).