From: Erik de Castro Lopo <mle+tools@mega-nerd.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4632] Copy siginfo.si_code.
Date: Sat, 31 May 2008 13:08:59 +1000 [thread overview]
Message-ID: <20080531130859.6563a53b.mle+tools@mega-nerd.com> (raw)
In-Reply-To: <E1K2DXF-0006Un-1h@cvs.savannah.gnu.org>
Paul Brook wrote:
> Revision: 4632
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4632
> Author: pbrook
> Date: 2008-05-30 22:57:20 +0000 (Fri, 30 May 2008)
>
> Log Message:
> -----------
> Copy siginfo.si_code.
>
> Modified Paths:
> --------------
> trunk/linux-user/signal.c
Sorry Paul, this commit broke the build.
> ===================================================================
> --- trunk/linux-user/signal.c 2008-05-30 22:37:07 UTC (rev 4631)
> +++ trunk/linux-user/signal.c 2008-05-30 22:57:20 UTC (rev 4632)
> @@ -216,7 +216,7 @@
> sig = host_to_target_signal(info->si_signo);
> tinfo->si_signo = sig;
> tinfo->si_errno = 0;
> - tinfo->si_code = 0;
> + tinfo->si_code = info.si_code;
That is definitely not right. According to the code 4 lines earlier,
info is a pointer and you a treating it like a struct.
Erik
--
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"C++ is the only current language making COBOL look good."
-- Bertrand Meyer
next prev parent reply other threads:[~2008-05-31 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 22:57 [Qemu-devel] [4632] Copy siginfo.si_code Paul Brook
2008-05-31 3:08 ` Erik de Castro Lopo [this message]
2008-05-31 12:15 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080531130859.6563a53b.mle+tools@mega-nerd.com \
--to=mle+tools@mega-nerd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).