From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K2HSw-0001Hy-6h
	for qemu-devel@nongnu.org; Fri, 30 May 2008 23:09:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K2HSt-0001Ej-7R
	for qemu-devel@nongnu.org; Fri, 30 May 2008 23:09:09 -0400
Received: from [199.232.76.173] (port=39782 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K2HSt-0001EX-0Z
	for qemu-devel@nongnu.org; Fri, 30 May 2008 23:09:07 -0400
Received: from smtp.syd.people.net.au ([218.214.225.98]:50214)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <mle+tools@mega-nerd.com>) id 1K2HSs-0006la-Bf
	for qemu-devel@nongnu.org; Fri, 30 May 2008 23:09:06 -0400
Received: from hendrix (hendrix [192.168.200.99])
	by hendrix.mega-nerd.net (Postfix) with SMTP id 5C0AEAB17D
	for <qemu-devel@nongnu.org>; Sat, 31 May 2008 13:08:59 +1000 (EST)
Date: Sat, 31 May 2008 13:08:59 +1000
From: Erik de Castro Lopo <mle+tools@mega-nerd.com>
Subject: Re: [Qemu-devel] [4632] Copy siginfo.si_code.
Message-Id: <20080531130859.6563a53b.mle+tools@mega-nerd.com>
In-Reply-To: <E1K2DXF-0006Un-1h@cvs.savannah.gnu.org>
References: <E1K2DXF-0006Un-1h@cvs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook wrote:

> Revision: 4632
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4632
> Author:   pbrook
> Date:     2008-05-30 22:57:20 +0000 (Fri, 30 May 2008)
> 
> Log Message:
> -----------
> Copy siginfo.si_code.
> 
> Modified Paths:
> --------------
>     trunk/linux-user/signal.c

Sorry Paul, this commit broke the build.

> ===================================================================
> --- trunk/linux-user/signal.c	2008-05-30 22:37:07 UTC (rev 4631)
> +++ trunk/linux-user/signal.c	2008-05-30 22:57:20 UTC (rev 4632)
> @@ -216,7 +216,7 @@
>      sig = host_to_target_signal(info->si_signo);
>      tinfo->si_signo = sig;
>      tinfo->si_errno = 0;
> -    tinfo->si_code = 0;
> +    tinfo->si_code = info.si_code;

That is definitely not right. According to the code 4 lines earlier,
info is a pointer and you a treating it like a struct.

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"C++ is the only current language making COBOL look good."
-- Bertrand Meyer