* [Qemu-devel] [4632] Copy siginfo.si_code.
@ 2008-05-30 22:57 Paul Brook
2008-05-31 3:08 ` Erik de Castro Lopo
0 siblings, 1 reply; 3+ messages in thread
From: Paul Brook @ 2008-05-30 22:57 UTC (permalink / raw)
To: qemu-devel
Revision: 4632
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4632
Author: pbrook
Date: 2008-05-30 22:57:20 +0000 (Fri, 30 May 2008)
Log Message:
-----------
Copy siginfo.si_code.
Modified Paths:
--------------
trunk/linux-user/signal.c
Modified: trunk/linux-user/signal.c
===================================================================
--- trunk/linux-user/signal.c 2008-05-30 22:37:07 UTC (rev 4631)
+++ trunk/linux-user/signal.c 2008-05-30 22:57:20 UTC (rev 4632)
@@ -216,7 +216,7 @@
sig = host_to_target_signal(info->si_signo);
tinfo->si_signo = sig;
tinfo->si_errno = 0;
- tinfo->si_code = 0;
+ tinfo->si_code = info.si_code;
if (sig == SIGILL || sig == SIGFPE || sig == SIGSEGV ||
sig == SIGBUS || sig == SIGTRAP) {
/* should never come here, but who knows. The information for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [4632] Copy siginfo.si_code.
2008-05-30 22:57 [Qemu-devel] [4632] Copy siginfo.si_code Paul Brook
@ 2008-05-31 3:08 ` Erik de Castro Lopo
2008-05-31 12:15 ` Paul Brook
0 siblings, 1 reply; 3+ messages in thread
From: Erik de Castro Lopo @ 2008-05-31 3:08 UTC (permalink / raw)
To: qemu-devel
Paul Brook wrote:
> Revision: 4632
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4632
> Author: pbrook
> Date: 2008-05-30 22:57:20 +0000 (Fri, 30 May 2008)
>
> Log Message:
> -----------
> Copy siginfo.si_code.
>
> Modified Paths:
> --------------
> trunk/linux-user/signal.c
Sorry Paul, this commit broke the build.
> ===================================================================
> --- trunk/linux-user/signal.c 2008-05-30 22:37:07 UTC (rev 4631)
> +++ trunk/linux-user/signal.c 2008-05-30 22:57:20 UTC (rev 4632)
> @@ -216,7 +216,7 @@
> sig = host_to_target_signal(info->si_signo);
> tinfo->si_signo = sig;
> tinfo->si_errno = 0;
> - tinfo->si_code = 0;
> + tinfo->si_code = info.si_code;
That is definitely not right. According to the code 4 lines earlier,
info is a pointer and you a treating it like a struct.
Erik
--
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"C++ is the only current language making COBOL look good."
-- Bertrand Meyer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [4632] Copy siginfo.si_code.
2008-05-31 3:08 ` Erik de Castro Lopo
@ 2008-05-31 12:15 ` Paul Brook
0 siblings, 0 replies; 3+ messages in thread
From: Paul Brook @ 2008-05-31 12:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Erik de Castro Lopo
> > Log Message:
> > -----------
> > Copy siginfo.si_code.
>
> this commit broke the build.
Fixed, sorry about that. I thought I'd tested this and everything built fine,
apparently I missed something.
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-31 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 22:57 [Qemu-devel] [4632] Copy siginfo.si_code Paul Brook
2008-05-31 3:08 ` Erik de Castro Lopo
2008-05-31 12:15 ` Paul Brook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).