From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K2RoB-0005L7-PA
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:11:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K2Ro9-0005Kh-Af
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:11:46 -0400
Received: from [199.232.76.173] (port=54105 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K2Ro9-0005KU-3v
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:11:45 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:41523)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1K2Ro8-0001hx-QX
	for qemu-devel@nongnu.org; Sat, 31 May 2008 10:11:45 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] Report exact PC on watchpoint hit
Date: Sat, 31 May 2008 15:11:39 +0100
References: <48414AC8.7080206@web.de> <484151E8.6050806@web.de>
In-Reply-To: <484151E8.6050806@web.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200805311511.39508.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>

> @@ -2395,6 +2396,11 @@ static target_ulong check_watchpoint(tar
> +                if (env->current_tb) {
> +                    tb_addr = env->current_tb->page_addr[0];
> +                    tb_invalidate_phys_page_range(tb_addr,
> +                                            tb_addr+TARGET_PAGE_SIZE-1,

This is wrong. env->current_tb is not what you think it it is. TB chaining 
means we may be an any TB reachable from there.

Paul