qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "M. Warner Losh" <imp@bsdimp.com>
To: berrange@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X
Date: Mon, 02 Jun 2008 15:12:15 -0600 (MDT)	[thread overview]
Message-ID: <20080602.151215.-1350519656.imp@bsdimp.com> (raw)
In-Reply-To: <20080602175417.GA19245@redhat.com>

In message: <20080602175417.GA19245@redhat.com>
            "Daniel P. Berrange" <berrange@redhat.com> writes:
: On Mon, Jun 02, 2008 at 11:44:17AM -0600, C.W. Betts wrote:
: > The following is a patch to make qemu-nbd compile on Mac OS X Leopard  
: > (any other versions are untested)
: > 
: > Index: qemu-nbd.c
: > ===================================================================
: > --- qemu-nbd.c	(revision 4654)
: > +++ qemu-nbd.c	(working copy)
: > @@ -21,7 +21,11 @@
: >  #include "block_int.h"
: >  #include "nbd.h"
: > 
: > +#ifdef __APPLE__
: > +#include <malloc/malloc.h>
: > +#else
: >  #include <malloc.h>
: > +#endif
: 
: 
: The include of malloc.h looks rather bogus to me. malloc() is part
: of stdlib.h, and is not even used in this file anyway. It compiles fine
: on Linux if you remove include of malloc.h entirely

Yes.  Years ago, malloc.h was typically needed for SunOS 4.x
compatibility.  Once malloc was codified to live in stdlib.h, malloc.h
was deprecated.

Warner

      parent reply	other threads:[~2008-06-02 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4A9FE33F-BC49-4881-84CB-A751CCADB36D@hotmail.com>
2008-06-02 17:44 ` [Qemu-devel] [patch] Make qemu-nbd compile on OS X C.W. Betts
2008-06-02 18:21   ` Laurent Vivier
2008-06-02 17:54 ` Daniel P. Berrange
2008-06-02 18:34   ` Laurent Vivier
2008-06-02 21:12   ` M. Warner Losh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080602.151215.-1350519656.imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).