From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X
Date: Mon, 2 Jun 2008 18:54:17 +0100 [thread overview]
Message-ID: <20080602175417.GA19245@redhat.com> (raw)
In-Reply-To: <4A9FE33F-BC49-4881-84CB-A751CCADB36D@hotmail.com>
On Mon, Jun 02, 2008 at 11:44:17AM -0600, C.W. Betts wrote:
> The following is a patch to make qemu-nbd compile on Mac OS X Leopard
> (any other versions are untested)
>
> Index: qemu-nbd.c
> ===================================================================
> --- qemu-nbd.c (revision 4654)
> +++ qemu-nbd.c (working copy)
> @@ -21,7 +21,11 @@
> #include "block_int.h"
> #include "nbd.h"
>
> +#ifdef __APPLE__
> +#include <malloc/malloc.h>
> +#else
> #include <malloc.h>
> +#endif
The include of malloc.h looks rather bogus to me. malloc() is part
of stdlib.h, and is not even used in this file anyway. It compiles fine
on Linux if you remove include of malloc.h entirely
Regards,
Daniel.
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
next prev parent reply other threads:[~2008-06-02 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A9FE33F-BC49-4881-84CB-A751CCADB36D@hotmail.com>
2008-06-02 17:44 ` [Qemu-devel] [patch] Make qemu-nbd compile on OS X C.W. Betts
2008-06-02 18:21 ` Laurent Vivier
2008-06-02 17:54 ` Daniel P. Berrange [this message]
2008-06-02 18:34 ` Laurent Vivier
2008-06-02 21:12 ` M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602175417.GA19245@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).