From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K3EEn-0002LJ-6N
	for qemu-devel@nongnu.org; Mon, 02 Jun 2008 13:54:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K3EEj-0002Ec-9B
	for qemu-devel@nongnu.org; Mon, 02 Jun 2008 13:54:28 -0400
Received: from [199.232.76.173] (port=54424 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K3EEj-0002EP-5E
	for qemu-devel@nongnu.org; Mon, 02 Jun 2008 13:54:25 -0400
Received: from mx1.redhat.com ([66.187.233.31]:56920)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1K3EEj-0001X4-Bm
	for qemu-devel@nongnu.org; Mon, 02 Jun 2008 13:54:25 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m52HsILa006540
	for <qemu-devel@nongnu.org>; Mon, 2 Jun 2008 13:54:18 -0400
Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6])
	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m52HsHAh006477
	for <qemu-devel@nongnu.org>; Mon, 2 Jun 2008 13:54:18 -0400
Received: (from berrange@localhost)
	by file.fab.redhat.com (8.13.1/8.13.1/Submit) id m52HsHTi019885
	for qemu-devel@nongnu.org; Mon, 2 Jun 2008 18:54:17 +0100
Date: Mon, 2 Jun 2008 18:54:17 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [patch] Make qemu-nbd compile on OS X
Message-ID: <20080602175417.GA19245@redhat.com>
References: <4A9FE33F-BC49-4881-84CB-A751CCADB36D@hotmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A9FE33F-BC49-4881-84CB-A751CCADB36D@hotmail.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Jun 02, 2008 at 11:44:17AM -0600, C.W. Betts wrote:
> The following is a patch to make qemu-nbd compile on Mac OS X Leopard  
> (any other versions are untested)
> 
> Index: qemu-nbd.c
> ===================================================================
> --- qemu-nbd.c	(revision 4654)
> +++ qemu-nbd.c	(working copy)
> @@ -21,7 +21,11 @@
>  #include "block_int.h"
>  #include "nbd.h"
> 
> +#ifdef __APPLE__
> +#include <malloc/malloc.h>
> +#else
>  #include <malloc.h>
> +#endif


The include of malloc.h looks rather bogus to me. malloc() is part
of stdlib.h, and is not even used in this file anyway. It compiles fine
on Linux if you remove include of malloc.h entirely

Regards,
Daniel.
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|