From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3dLh-00044L-LK for qemu-devel@nongnu.org; Tue, 03 Jun 2008 16:43:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3dLf-00042C-O8 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 16:43:17 -0400 Received: from [199.232.76.173] (port=40096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3dLf-00041y-Gy for qemu-devel@nongnu.org; Tue, 03 Jun 2008 16:43:15 -0400 Received: from mail2.shareable.org ([80.68.89.115]:35507) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3dLf-0001Q3-I2 for qemu-devel@nongnu.org; Tue, 03 Jun 2008 16:43:15 -0400 Received: from jamie by mail2.shareable.org with local (Exim 4.63) (envelope-from ) id 1K3dLd-0002eH-NI for qemu-devel@nongnu.org; Tue, 03 Jun 2008 21:43:13 +0100 Date: Tue, 3 Jun 2008 21:43:13 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] New qemu-img convert -B option to preserve the COW aspect of images and/or re-base them Message-ID: <20080603204313.GA9995@shareable.org> References: <48459641.5040000@codemonkey.ws> <20080603194041.GE6899@shareable.org> <4845A5C4.6050309@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4845A5C4.6050309@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > It's sloppy. In general, using a non-portable feature for no good > reason other than you can is bad practice (even if we do depend on GCC). It's 2008, the standard is called C99 for a reason. In 1998, we would have used C89 constructs like function prototypes, wouldn't we? :-) If you don't want to use non-portable features, may I suggest "gcc -std=c89". (Half joking, I use -Wdeclaration-after-statement myself to catch this, since it became a standard GCC feature with no option to turn it off and keep other GNU extensions. But then, I write code which is more portable than QEMU and target older architectures.) -- Jamie