qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand
Date: Thu, 5 Jun 2008 02:26:42 +0100	[thread overview]
Message-ID: <200806050226.42967.paul@codesourcery.com> (raw)
In-Reply-To: <4846DD33.2070206@web.de>

[foreach_cpu]
> > I tend to dislike such macros...
>
> Why?

I agree with Fabrice in this case. Iterating over all cpus isn't a 
particularly onerous task to start with. Using bizarre macros means that the 
code no longer looks like normal C.

> My debugger SMP fix already comes with 5 more use cases.

I'm unconvinced by SMP debugger support. FSF gdb isn't currently capable of 
handling SMP targets, so whatever you're doing is likely to be an ugly hack.

Paul

  parent reply	other threads:[~2008-06-05  1:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 19:56 [Qemu-devel] [PATCH] Introduce foreach_cpu shorthand Jan Kiszka
2008-06-03 20:18 ` Anthony Liguori
2008-06-04 12:39 ` Fabrice Bellard
2008-06-04 18:21   ` [Qemu-devel] " Jan Kiszka
2008-06-04 22:01     ` Thiemo Seufer
2008-06-04 22:29       ` Jan Kiszka
2008-06-05  1:26     ` Paul Brook [this message]
2008-06-05  7:11       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806050226.42967.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).