From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K44Fr-0000RP-J1 for qemu-devel@nongnu.org; Wed, 04 Jun 2008 21:27:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K44Fn-0000MU-1t for qemu-devel@nongnu.org; Wed, 04 Jun 2008 21:27:03 -0400 Received: from [199.232.76.173] (port=42999 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K44Fm-0000MI-UF for qemu-devel@nongnu.org; Wed, 04 Jun 2008 21:26:58 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:50161) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K44Fm-0005ZN-F6 for qemu-devel@nongnu.org; Wed, 04 Jun 2008 21:26:58 -0400 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH] Introduce foreach_cpu shorthand Date: Thu, 5 Jun 2008 02:26:42 +0100 References: <4845A1D6.5050005@web.de> <48468CED.9000706@bellard.org> <4846DD33.2070206@web.de> In-Reply-To: <4846DD33.2070206@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806050226.42967.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka [foreach_cpu] > > I tend to dislike such macros... > > Why? I agree with Fabrice in this case. Iterating over all cpus isn't a particularly onerous task to start with. Using bizarre macros means that the code no longer looks like normal C. > My debugger SMP fix already comes with 5 more use cases. I'm unconvinced by SMP debugger support. FSF gdb isn't currently capable of handling SMP targets, so whatever you're doing is likely to be an ugly hack. Paul