From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K4Lwm-0003KL-Og
	for qemu-devel@nongnu.org; Thu, 05 Jun 2008 16:20:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K4Lwh-0003J6-E5
	for qemu-devel@nongnu.org; Thu, 05 Jun 2008 16:20:31 -0400
Received: from [199.232.76.173] (port=54414 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K4Lwh-0003J3-96
	for qemu-devel@nongnu.org; Thu, 05 Jun 2008 16:20:27 -0400
Received: from il.qumranet.com ([212.179.150.194]:53758)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1K4Lwg-0004eh-U5
	for qemu-devel@nongnu.org; Thu, 05 Jun 2008 16:20:27 -0400
Received: from gleb-debian.qumranet.com (unknown [172.16.15.143])
	by il.qumranet.com (Postfix) with ESMTP id C872D250A43
	for <qemu-devel@nongnu.org>; Thu,  5 Jun 2008 23:20:24 +0300 (IDT)
Date: Thu, 5 Jun 2008 23:20:24 +0300
Subject: Re: [Qemu-devel] [PATCH 4/5] Use libuuid if available.
Message-ID: <20080605202024.GA11941@minantech.com>
References: <20080605083536.11678.439.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080605083551.11678.57336.stgit@gleb-debian.qumranet.com.qumranet.com>
	<484803B7.50908@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <484803B7.50908@codemonkey.ws>
From: gleb@qumranet.com (Gleb Natapov)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony, thanks for the review.

On Thu, Jun 05, 2008 at 10:18:15AM -0500, Anthony Liguori wrote:
>> @@ -256,8 +260,14 @@ static void do_info_name(void)
>>   static void do_info_uuid(void)
>>  {
>> +#ifdef CONFIG_UUID
>> +    char uuid_str[37];
>> +    uuid_unparse(qemu_uuid, uuid_str);
>> +    term_printf("%s\n", uuid_str);
>> +#else
>>   
>
> Just use a printf() string here again to eliminate the need for CONFIG_UUID.
>
So may be do not use libuuid at all and just write simple uuid string
parsing function?

--
			Gleb.