From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K5UCr-0004nw-0y
	for qemu-devel@nongnu.org; Sun, 08 Jun 2008 19:21:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K5UCo-0004mK-Is
	for qemu-devel@nongnu.org; Sun, 08 Jun 2008 19:21:47 -0400
Received: from [199.232.76.173] (port=58702 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K5UCo-0004mH-DX
	for qemu-devel@nongnu.org; Sun, 08 Jun 2008 19:21:46 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:47983)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1K5UCo-0002ta-MM
	for qemu-devel@nongnu.org; Sun, 08 Jun 2008 19:21:47 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH] TC6393xb update: support system features
Date: Mon, 9 Jun 2008 00:21:23 +0100
References: <20080605181156.GA24695@doriath.ww600.siemens.net>
	<20080608072038.GA6198@doriath.ww600.siemens.net>
	<fb249edb0806081606pb8cdfex82756fac4f70c39f@mail.gmail.com>
In-Reply-To: <fb249edb0806081606pb8cdfex82756fac4f70c39f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806090021.23624.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Monday 09 June 2008, andrzej zaborowski wrote:
> Hi,
>
> On 08/06/2008, Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> > Any comments about this? TC6393xb is a multifunctional device as found
> >  in tosa or some toshibe e-series PDAs. And this provides some partial
> >  emulation of it's features.
>
> Committed, thanks.  Perhaps it's good to have at least a short license
> notice 

Licence notes and at least basic copyright information should definitely be 
required.

> and a note on what the device does or who produces it. I think 
> it's not a policy though.

I'd also strongly recommend that these be added.  I find it very useful to 
have a short comment saying exactly what device we're trying to emulate.

> +/* vim:set shiftwidth=4 ts=4 et: */

We can loose this though.

Paul