From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][RESEND] ide: fix ATAPI read drive structure command (v3)
Date: Mon, 9 Jun 2008 03:52:20 -0500 [thread overview]
Message-ID: <20080609085220.GA24218@tapir> (raw)
In-Reply-To: <1212977645.10496.217.camel@bling>
On Sun, Jun 08, 2008 at 08:14:05PM -0600, Alex Williamson wrote:
> Hi,
>
> Resend of patch from last week. This has been review by Alexander Graf
> and Anthony Liguori. The patch fixes diskpart.exe working in Vista when
> a DVD image is loaded. Please apply to trunk. Thanks,
Tested it with Linux/OpenSolaris guests and confirmed no obvious regressions
but I haven't traced specifically calls to this function (as used by diskpart
in Vista).
> + if (format < 0xff && media_is_cd(s)) {
> ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST,
> - ASC_INV_FIELD_IN_CMD_PACKET);
> + ASC_INCOMPATIBLE_FORMAT);
> + break;
couldn't find a reference to this in MMC6's READ DISK STRUCTURE command, why
is format = 0xff allowed if the media is a CD, what about when there is no
media?
Carlo
next prev parent reply other threads:[~2008-06-09 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 2:14 [Qemu-devel] [PATCH][RESEND] ide: fix ATAPI read drive structure command (v3) Alex Williamson
2008-06-09 8:52 ` Carlo Marcelo Arenas Belon [this message]
2008-06-10 12:21 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609085220.GA24218@tapir \
--to=carenas@sajinet.com.pe \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).