From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K5clL-0003Am-0l
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:29:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K5clI-0003A5-OK
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:29:58 -0400
Received: from [199.232.76.173] (port=45693 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K5clI-00039q-30
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:29:56 -0400
Received: from tapir.sajinet.com.pe ([66.139.79.212]:38274)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <carenas@sajinet.com.pe>) id 1K5clI-0002jJ-5X
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:29:56 -0400
Date: Mon, 9 Jun 2008 03:52:20 -0500
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
Subject: Re: [Qemu-devel] [PATCH][RESEND] ide: fix ATAPI read drive structure
	command (v3)
Message-ID: <20080609085220.GA24218@tapir>
References: <1212977645.10496.217.camel@bling>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1212977645.10496.217.camel@bling>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Jun 08, 2008 at 08:14:05PM -0600, Alex Williamson wrote:
> Hi,
> 
> Resend of patch from last week.  This has been review by Alexander Graf
> and Anthony Liguori.  The patch fixes diskpart.exe working in Vista when
> a DVD image is loaded.  Please apply to trunk.  Thanks,

Tested it with Linux/OpenSolaris guests and confirmed no obvious regressions
but I haven't traced specifically calls to this function (as used by diskpart
in Vista).

> +            if (format < 0xff && media_is_cd(s)) {
>                  ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST,
> -                                    ASC_INV_FIELD_IN_CMD_PACKET);
> +                                    ASC_INCOMPATIBLE_FORMAT);
> +                break;

couldn't find a reference to this in MMC6's READ DISK STRUCTURE command, why
is format = 0xff allowed if the media is a CD, what about when there is no
media?

Carlo