From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Subject: Re: [Qemu-devel] [PATCH] Proposed fix broken RST response to a slirp redirect socket
Date: Wed, 11 Jun 2008 22:29:37 +0200 [thread overview]
Message-ID: <20080611202937.GC20729@edgar.se.axis.com> (raw)
In-Reply-To: <4850313B.8030304@windriver.com>
On Wed, Jun 11, 2008 at 03:10:35PM -0500, Jason Wessel wrote:
> + int err;
> + socklen_t slen;
> +
> + err = errno;
>
> ---
>
> Probably don't need to set err to errno since you are collecting it with getsockopt
Please note that the errno value is used when nn < 0.
>
> ---
>
> + if (nn == 0)
> + getsockopt(so->s, SOL_SOCKET, SO_ERROR,
> + &err, &slen);
>
> ---
>
> In theory you are supposed to set slen = sizeof(err); prior to calling getsockopt()
Thanks, I'll fix that up.
Best regards
--
Edgar E. Iglesias
Axis Communications AB
next prev parent reply other threads:[~2008-06-11 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 17:21 [Qemu-devel] [PATCH] Proposed fix broken RST response to a slirp redirect socket Jason Wessel
2008-06-11 18:07 ` Edgar E. Iglesias
2008-06-11 19:37 ` Edgar E. Iglesias
2008-06-11 20:10 ` Jason Wessel
2008-06-11 20:29 ` Edgar E. Iglesias [this message]
2008-06-11 21:14 ` Jason Wessel
2008-06-11 21:47 ` [Qemu-devel] [PATCH] slirp: Propagate host TCP RST to the guest Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080611202937.GC20729@edgar.se.axis.com \
--to=edgar.iglesias@axis.com \
--cc=jason.wessel@windriver.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).