From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] buffer overruns in qemu-system-sparc (hw/eccmemctl.c: ecc_reset())
Date: Wed, 18 Jun 2008 00:37:32 +0100 [thread overview]
Message-ID: <200806180037.33639.paul@codesourcery.com> (raw)
In-Reply-To: <200806172235.19974.jseward@acm.org>
On Tuesday 17 June 2008, Julian Seward wrote:
> + int four = sizeof(s->regs[0]);
You're joking, right?
Either you know the value and you should use an actual number "4", or it might
not be 4, and you should call the variable something sensible.
Either way It should not be a modifiable variable.
Paul
next prev parent reply other threads:[~2008-06-17 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 20:35 [Qemu-devel] buffer overruns in qemu-system-sparc (hw/eccmemctl.c: ecc_reset()) Julian Seward
2008-06-17 23:37 ` Paul Brook [this message]
2008-06-17 23:38 ` Robert Reif
2008-06-17 23:58 ` Julian Seward
2008-06-19 14:11 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806180037.33639.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).