From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8kk8-00029n-6f for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:37:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8kk6-00029Y-S1 for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:37:39 -0400 Received: from [199.232.76.173] (port=37601 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8kk6-00029V-M7 for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:37:38 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:39320) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K8kk6-0007BY-M5 for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:37:38 -0400 From: Paul Brook Subject: Re: [Qemu-devel] buffer overruns in qemu-system-sparc (hw/eccmemctl.c: ecc_reset()) Date: Wed, 18 Jun 2008 00:37:32 +0100 References: <200806172235.19974.jseward@acm.org> In-Reply-To: <200806172235.19974.jseward@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200806180037.33639.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tuesday 17 June 2008, Julian Seward wrote: > + =A0 =A0int four =3D sizeof(s->regs[0]); You're joking, right? Either you know the value and you should use an actual number "4", or it mi= ght=20 not be 4, and you should call the variable something sensible.=20 Either way It should not be a modifiable variable. Paul