From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8kdT-0008Mv-GD for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:30:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8kdS-0008MF-0o for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:30:47 -0400 Received: from [199.232.76.173] (port=49980 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8kdR-0008M2-GM for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:30:45 -0400 Received: from server1linux.rebelnetworks.com ([66.135.44.167]:50268) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K8kdR-0005Q5-0e for qemu-devel@nongnu.org; Tue, 17 Jun 2008 19:30:45 -0400 Received: from p5b1653e2.dip.t-dialin.net ([91.22.83.226] helo=phoenix2.frop.org) by server1linux.rebelnetworks.com with esmtpa (Exim 4.68) (envelope-from ) id 1K8kdD-0000ge-9S for qemu-devel@nongnu.org; Tue, 17 Jun 2008 18:30:31 -0500 From: Julian Seward Subject: Re: [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA, OV} in addme, subfme, mullwo Date: Wed, 18 Jun 2008 01:23:49 +0200 References: <200805110204.47184.jseward@acm.org> <200806180006.51954.jseward@acm.org> <1213743222.19143.22.camel@localhost> In-Reply-To: <1213743222.19143.22.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806180123.49284.jseward@acm.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wednesday 18 June 2008 00:53, J. Mayer wrote: > This patch looks really ugly, does not respect the coding style and > addme/subme changes seem very suspicious to me... Thanks for the encouragement. > Could you please exactly describe the test conditions (host, ...) ? Core 2 Duo, openSUSE 10.2, 64-bit mode, gcc-3.4.6, qemu svn trunk from 2 days ago. J