From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K8lBC-0000yW-Qs
	for qemu-devel@nongnu.org; Tue, 17 Jun 2008 20:05:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K8lBB-0000x6-6A
	for qemu-devel@nongnu.org; Tue, 17 Jun 2008 20:05:38 -0400
Received: from [199.232.76.173] (port=44055 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K8lBB-0000wy-2a
	for qemu-devel@nongnu.org; Tue, 17 Jun 2008 20:05:37 -0400
Received: from server1linux.rebelnetworks.com ([66.135.44.167]:37723)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jseward@acm.org>) id 1K8lBA-0000bj-Hw
	for qemu-devel@nongnu.org; Tue, 17 Jun 2008 20:05:36 -0400
From: Julian Seward <jseward@acm.org>
Subject: Re: [Qemu-devel] buffer overruns in qemu-system-sparc
	(hw/eccmemctl.c: ecc_reset())
Date: Wed, 18 Jun 2008 01:58:44 +0200
References: <200806172235.19974.jseward@acm.org>
	<48584B13.7000503@earthlink.net>
In-Reply-To: <48584B13.7000503@earthlink.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806180158.44386.jseward@acm.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Robert Reif <reif@earthlink.net>

On Wednesday 18 June 2008 01:38, Robert Reif wrote:

> Here is a little cleaner version:

Yes, that is saner.

I see you removed the loop

    for (i = 1; i < ECC_NREGS; i++)
        s->regs[i] = 0;

Did that have some significance?  Its presence seemed very strange
to me.

J