From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K95UL-0007UX-14
	for qemu-devel@nongnu.org; Wed, 18 Jun 2008 17:46:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K95UJ-0007Th-6d
	for qemu-devel@nongnu.org; Wed, 18 Jun 2008 17:46:44 -0400
Received: from [199.232.76.173] (port=33049 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K95UI-0007Tb-T7
	for qemu-devel@nongnu.org; Wed, 18 Jun 2008 17:46:42 -0400
Received: from server1linux.rebelnetworks.com ([66.135.44.167]:43028)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jseward@acm.org>) id 1K95UI-0002gQ-M4
	for qemu-devel@nongnu.org; Wed, 18 Jun 2008 17:46:42 -0400
Received: from p5b1675da.dip.t-dialin.net ([91.22.117.218]
	helo=phoenix2.frop.org)
	by server1linux.rebelnetworks.com with esmtpa (Exim 4.68)
	(envelope-from <jseward@acm.org>) id 1K95Tt-0001HV-Uk
	for qemu-devel@nongnu.org; Wed, 18 Jun 2008 16:46:18 -0500
From: Julian Seward <jseward@acm.org>
Subject: Re: [Qemu-devel] [PATCH] ppc32 guests: fix computation of XER.{CA,
	OV} in addme, subfme, mullwo
Date: Wed, 18 Jun 2008 23:39:32 +0200
References: <200805110204.47184.jseward@acm.org>
	<200806180123.49284.jseward@acm.org>
	<1213824735.19143.35.camel@localhost>
In-Reply-To: <1213824735.19143.35.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806182339.32714.jseward@acm.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


On Wednesday 18 June 2008 23:32, J. Mayer wrote:
> Looking at the (relativelly) recent changes in this code, I can see that
> I did an optimization that seems correct at first sight but... 
> [ .. big patch deleted .. ]
> Do you feel like this patch is buggy ?

Why don't you just commit the patch I sent?  It's shorter, it
fixes the problem I reported and it does not cause any regressions.

J