From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: "J. Mayer" <l_indien@magic.fr>
Subject: Re: [Qemu-devel] [4799] Add instruction counter.
Date: Sun, 29 Jun 2008 13:28:35 +0100 [thread overview]
Message-ID: <200806291328.37945.paul@codesourcery.com> (raw)
In-Reply-To: <1214740636.30251.11.camel@localhost>
> + int done_init = 0;
> + if (done_init)
> + return;
> + cpu_env = tcg_global_reg_new(TCG_TYPE_PTR, TCG_AREG0, "env");
> + done_init = 1;
> +}
>
> - done_init is on the stack, thus will never be 1.
Fixed.
> - why isn't this variable / code shared with other targets (can see the
> exact same code in Alpha target...) ?
Maybe. Most targets have many globals and cpu_env is the only one that's
really target independent. alpha and ppc are only the same because they still
haven't been converted to TCG.
Paul
next prev parent reply other threads:[~2008-06-29 12:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 1:03 [Qemu-devel] [4799] Add instruction counter Paul Brook
[not found] ` <6D074CEF-5086-4301-A19C-F1E76E6B313D@hotmail.com>
2008-06-29 4:44 ` C.W. Betts
2008-06-29 9:58 ` Laurent Desnogues
2008-06-29 11:57 ` J. Mayer
2008-06-29 12:28 ` Paul Brook [this message]
2008-06-29 13:12 ` J. Mayer
2008-06-29 18:44 ` Stuart Brady
2008-06-29 12:37 ` [Qemu-devel] " Jan Kiszka
2008-06-29 13:16 ` Paul Brook
2008-06-29 13:54 ` Jan Kiszka
2008-06-29 14:31 ` Paul Brook
2008-07-10 23:04 ` [Qemu-devel] " Robert Reif
2008-07-11 16:42 ` Blue Swirl
2008-07-11 16:59 ` Julian Seward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806291328.37945.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=l_indien@magic.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).