qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@qumranet.com>
To: Avi Kivity <avi@qumranet.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information.
Date: Sun, 29 Jun 2008 17:18:52 +0300	[thread overview]
Message-ID: <20080629141852.GD31298@minantech.com> (raw)
In-Reply-To: <486798A9.7060308@qumranet.com>

On Sun, Jun 29, 2008 at 05:14:01PM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> The return value is less then zero if interrupt is masked, zero if it
>> is known that interrupt is lost (due to coalescing) or greater then zero
>> if interrupt is delivered or was successfully queued for delivery by
>> interrupt controller. Device emulation can use this info as it pleases.
>> Included patch adds detection of interrupt coalescing into PIC and APIC
>> code for edge triggered interrupts.
>>   
>
> Instead of negative/positive/zero, consider returning an enum for  
> readability.
>
I thought about that, but I sometimes do arithmetics on those values
(when delivering interrupt to multiple CPUs), so result can be more then
1 sometimes.

--
			Gleb.

  reply	other threads:[~2008-06-29 14:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-29 14:02 [Qemu-devel] [PATCH 0/3] Fix guest time drift under heavy load Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov
2008-06-29 14:14   ` Avi Kivity
2008-06-29 14:18     ` Gleb Natapov [this message]
2008-06-29 14:53       ` Paul Brook
2008-06-29 15:37         ` Gleb Natapov
2008-06-29 14:38   ` Paul Brook
2008-06-29 15:40     ` Gleb Natapov
2008-06-29 18:11       ` Paul Brook
2008-06-29 19:44         ` Gleb Natapov
2008-06-29 20:34           ` Paul Brook
2008-06-29 20:49             ` Gleb Natapov
2008-06-30 13:26               ` Gleb Natapov
2008-06-30 14:00                 ` Paul Brook
2008-06-30 14:28                   ` Gleb Natapov
2008-06-30 14:35                     ` Paul Brook
2008-06-29 20:58             ` [Qemu-devel] " Jan Kiszka
2008-06-29 21:16               ` Paul Brook
2008-06-29 21:42                 ` Dor Laor
2008-06-29 21:47                 ` Jan Kiszka
2008-06-29 21:54                   ` Paul Brook
2008-06-30 13:18               ` Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 2/3] Fix time drift problem under high load when PIT is in use Gleb Natapov
2008-06-29 14:40   ` [Qemu-devel] " Jan Kiszka
2008-06-29 15:52     ` Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 3/3] Fix time drift problem under high load when RTC " Gleb Natapov
2008-06-29 14:37 ` [Qemu-devel] Re: [PATCH 0/3] Fix guest time drift under heavy load Jan Kiszka
  -- strict thread matches above, loose matches on Subject: below --
2008-10-29 15:22 [Qemu-devel] [RESEND][PATCH " Gleb Natapov
2008-10-29 15:22 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov
2008-06-23 10:49 [Qemu-devel] [PATCH 0/3] Fix guest time drift under heavy load Gleb Natapov
2008-06-23 10:49 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080629141852.GD31298@minantech.com \
    --to=gleb@qumranet.com \
    --cc=avi@qumranet.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).