From: Gleb Natapov <gleb@qumranet.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information.
Date: Mon, 30 Jun 2008 16:26:52 +0300 [thread overview]
Message-ID: <20080630132652.GG31298@minantech.com> (raw)
In-Reply-To: <20080629204907.GB17476@minantech.com>
On Sun, Jun 29, 2008 at 11:49:07PM +0300, Gleb Natapov wrote:
> On Sun, Jun 29, 2008 at 09:34:08PM +0100, Paul Brook wrote:
> > > The model takes into account that not all interrupt controller are
> > > capable to detect missed interrupt (it is possible that there is no
> > > interrupt controller at all). In this case irq function should
> > > return one and everything will fall back to how it works now.
> >
> > On a related note the correct way to fix this is "-icount auto".
> > You should make sure that your hacks are not enabled when we have a realistic
> > virtual timebase.
> >
> Can you educate me what "-icount auto" is? Quick grep in qemu tree shows
> nothing.
>
I forgot to rebase my branch that is why grep showed nothing ;) But
there is no much documentation about virtual time base. I can't see why
this hack cannot coexist with virtual time base. If virtual time base
somehow guaranties that interrupts will never be lost then qemu_irq_rase()
will never return zero and the hack will be as good as disabled.
--
Gleb.
next prev parent reply other threads:[~2008-06-30 13:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 14:02 [Qemu-devel] [PATCH 0/3] Fix guest time drift under heavy load Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov
2008-06-29 14:14 ` Avi Kivity
2008-06-29 14:18 ` Gleb Natapov
2008-06-29 14:53 ` Paul Brook
2008-06-29 15:37 ` Gleb Natapov
2008-06-29 14:38 ` Paul Brook
2008-06-29 15:40 ` Gleb Natapov
2008-06-29 18:11 ` Paul Brook
2008-06-29 19:44 ` Gleb Natapov
2008-06-29 20:34 ` Paul Brook
2008-06-29 20:49 ` Gleb Natapov
2008-06-30 13:26 ` Gleb Natapov [this message]
2008-06-30 14:00 ` Paul Brook
2008-06-30 14:28 ` Gleb Natapov
2008-06-30 14:35 ` Paul Brook
2008-06-29 20:58 ` [Qemu-devel] " Jan Kiszka
2008-06-29 21:16 ` Paul Brook
2008-06-29 21:42 ` Dor Laor
2008-06-29 21:47 ` Jan Kiszka
2008-06-29 21:54 ` Paul Brook
2008-06-30 13:18 ` Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 2/3] Fix time drift problem under high load when PIT is in use Gleb Natapov
2008-06-29 14:40 ` [Qemu-devel] " Jan Kiszka
2008-06-29 15:52 ` Gleb Natapov
2008-06-29 14:02 ` [Qemu-devel] [PATCH 3/3] Fix time drift problem under high load when RTC " Gleb Natapov
2008-06-29 14:37 ` [Qemu-devel] Re: [PATCH 0/3] Fix guest time drift under heavy load Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2008-10-29 15:22 [Qemu-devel] [RESEND][PATCH " Gleb Natapov
2008-10-29 15:22 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov
2008-06-23 10:49 [Qemu-devel] [PATCH 0/3] Fix guest time drift under heavy load Gleb Natapov
2008-06-23 10:49 ` [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return status information Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630132652.GG31298@minantech.com \
--to=gleb@qumranet.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).