From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KDJPF-00077B-FI
	for qemu-devel@nongnu.org; Mon, 30 Jun 2008 09:26:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KDJPE-00073o-10
	for qemu-devel@nongnu.org; Mon, 30 Jun 2008 09:26:57 -0400
Received: from [199.232.76.173] (port=54972 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KDJPD-00073c-Nj
	for qemu-devel@nongnu.org; Mon, 30 Jun 2008 09:26:55 -0400
Received: from il.qumranet.com ([212.179.150.194]:52512)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1KDJPD-00026w-8b
	for qemu-devel@nongnu.org; Mon, 30 Jun 2008 09:26:55 -0400
Date: Mon, 30 Jun 2008 16:26:52 +0300
From: Gleb Natapov <gleb@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Change qemu_set_irq() to return
	status information.
Message-ID: <20080630132652.GG31298@minantech.com>
References: <20080629140120.5626.1590.stgit@gleb-debian.qumranet.com.qumranet.com>
	<200806291911.02093.paul@codesourcery.com>
	<20080629194412.GA17476@minantech.com>
	<200806292134.08436.paul@codesourcery.com>
	<20080629204907.GB17476@minantech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080629204907.GB17476@minantech.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Sun, Jun 29, 2008 at 11:49:07PM +0300, Gleb Natapov wrote:
> On Sun, Jun 29, 2008 at 09:34:08PM +0100, Paul Brook wrote:
> > > The model takes into account that not all interrupt controller are
> > > capable to detect missed interrupt (it is possible that there is no
> > > interrupt controller at all). In this case irq function should
> > > return one and everything will fall back to how it works now.
> > 
> > On a related note the correct way to fix this is "-icount auto".
> > You should make sure that your hacks are not enabled when we have a realistic 
> > virtual timebase.
> > 
> Can you educate me what "-icount auto" is? Quick grep in qemu tree shows
> nothing.
> 
I forgot to rebase my branch that is why grep showed nothing ;) But
there is no much documentation about virtual time base. I can't see why
this hack cannot coexist with virtual time base. If virtual time base
somehow guaranties that interrupts will never be lost then qemu_irq_rase()
will never return zero and the hack will be as good as disabled.

--
			Gleb.