From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KFGRf-0004G6-P1
	for qemu-devel@nongnu.org; Sat, 05 Jul 2008 18:41:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KFGRe-0004Fu-5V
	for qemu-devel@nongnu.org; Sat, 05 Jul 2008 18:41:30 -0400
Received: from [199.232.76.173] (port=55725 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KFGRe-0004Fr-09
	for qemu-devel@nongnu.org; Sat, 05 Jul 2008 18:41:30 -0400
Received: from mail2.shareable.org ([80.68.89.115]:38990)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1KFGRd-0000WV-PV
	for qemu-devel@nongnu.org; Sat, 05 Jul 2008 18:41:29 -0400
Date: Sat, 5 Jul 2008 23:41:22 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] Fix compilation of nbd on Windows
Message-ID: <20080705224121.GA1787@shareable.org>
References: <20080704092849.5BC0.20F538E7@nsfocus.com>
	<20080704023451.GO7007@networkno.de>
	<20080704115101.5BC9.20F538E7@nsfocus.com>
	<1215160927.3802.4.camel@frecb07144>
	<20080704203231.GB31670@networkno.de>
	<alpine.DEB.1.00.0807042148250.9925@racer>
	<alpine.DEB.1.00.0807042300550.9925@racer>
	<5b31733c0807050458w41aebd89re70cc859602c3681@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b31733c0807050458w41aebd89re70cc859602c3681@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, chenqing <chenqing@nsfocus.com>

Filip Navara wrote:
> Closing sockets with "close" doesn't work on WinSock. Add "#define
> close closesocket" to the top of file to fix it. Otherwise, good job!

Socket error handling is different too, you might want to check any
places errno is used in the socket code.  Also ioctl -> ioctlsocket
(but you probably don't use it).

Or look at the rest of QEMU, which surely does some Windows networking.

-- Jamie