From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KGGId-0003Iv-TF
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 12:44:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KGGIa-0003ID-0W
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 12:44:19 -0400
Received: from [199.232.76.173] (port=34848 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KGGIZ-0003IA-TW
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 12:44:15 -0400
Received: from hobi.com ([130.94.185.247]:4256)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rickv@hobi.com>) id 1KGGIZ-0007wE-Bn
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 12:44:15 -0400
Received: from unknown (HELO ricklap) ([68.23.60.237])
	(envelope-sender <rickv@hobi.com>)
	by 130.94.185.247 (qmail-ldap-1.03) with SMTP
	for <qemu-devel@nongnu.org>; 8 Jul 2008 16:44:13 -0000
From: Rick Vernam <rickv@hobi.com>
Subject: Re: [Qemu-devel] [PATCH] Initialize the VMware VGA console after
	vga_init
Date: Tue, 8 Jul 2008 11:44:12 -0500
References: <48737693.5030300@suse.de>
In-Reply-To: <48737693.5030300@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200807081144.12713.rickv@hobi.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Tuesday 08 July 2008 09:15:47 am Alexander Graf wrote:
> Hi,
>
> while trying the -vmwarevga switch I stumbled across this nifty problem:
> vga_common_init calls vga_reset, which memsets the whole VGAState to 0.
> Unfortunately the console initialization code is before that, so it gets
> overwritten by 0 which breaks later on.
>
> To circumvent this I reordered the console initialization to after the
> vga_init. I am not 100% sure if that's correct, but it works so far.
> Please double-check if this is the right approach.
>
> Alex
>
> Signed-off-by: Alexander Graf <agraf@suse.de>

Improvement here, as well.
Thanks!