From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KGEP5-0005I4-3k
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 10:42:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KGEP4-0005Hi-IH
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 10:42:50 -0400
Received: from [199.232.76.173] (port=51232 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KGEP4-0005Hf-Bg
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 10:42:50 -0400
Received: from il.qumranet.com ([212.179.150.194]:14919)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1KGEP3-0006Pv-JA
	for qemu-devel@nongnu.org; Tue, 08 Jul 2008 10:42:50 -0400
Date: Tue, 8 Jul 2008 17:42:46 +0300
From: Gleb Natapov <gleb@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] Fix time drift problem under high
	load when PIT is in use.
Message-ID: <20080708144246.GA11711@minantech.com>
References: <20080708111309.23652.81572.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080708111541.23652.99746.stgit@gleb-debian.qumranet.com.qumranet.com>
	<200807081452.52152.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200807081452.52152.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Tue, Jul 08, 2008 at 02:52:51PM +0100, Paul Brook wrote:
> On Tuesday 08 July 2008, Gleb Natapov wrote:
> > Count the number of interrupts that was lost due to interrupt coalescing
> > and re-inject them back when possible. This fixes time drift problem when
> > pit is used as a time source.
> 
> You apparently ignored my comments about not doing this when we have an 
> accurate virtual clock.
> 
What part do you want me to disable if virtual clock is enabled?
Interrupt re-injection in PIT/RTC code? Or do you what qemu_irq_set() to
always return 1 if virtual clock is enabled (this will effectively
disable the new interface and all its users will fall back to current
behaviour).

--
			Gleb.