From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] RFC: ARM prologue linkage fix
Date: Tue, 8 Jul 2008 21:43:46 +0100 [thread overview]
Message-ID: <200807082143.48545.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580807081225u1ca2522dy8af19d5458004b26@mail.gmail.com>
On Tuesday 08 July 2008, Blue Swirl wrote:
> Hi,
>
> I made a patch which allows sparc-linux-user target to be linked on an
> ARM host. Is this OK? Sparc32 helloworld program runs successfully,
> otherwise untested.
In principle it looks ok, however:
I think it deserves a comment in exec.c saying why we do this - the prologue
is reached via a direct jump, so must be placed close to the code segment.
Also, calling something .bss.code_gen, than placing it is .data is just asking
for trouble :-) I suggest calling the section ".gen_code".
We probably want the same thing on sparc and ppc hosts. I guess they can be
added as required though.
Paul
next prev parent reply other threads:[~2008-07-08 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 19:25 [Qemu-devel] RFC: ARM prologue linkage fix Blue Swirl
2008-07-08 20:43 ` Paul Brook [this message]
2008-07-10 15:36 ` Blue Swirl
2008-07-10 16:33 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807082143.48545.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).