From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KGK2W-0007NB-2v for qemu-devel@nongnu.org; Tue, 08 Jul 2008 16:43:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KGK2T-0007Mo-Jc for qemu-devel@nongnu.org; Tue, 08 Jul 2008 16:43:54 -0400 Received: from [199.232.76.173] (port=52572 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGK2T-0007Ml-F9 for qemu-devel@nongnu.org; Tue, 08 Jul 2008 16:43:53 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:42616) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KGK2T-0000lt-2C for qemu-devel@nongnu.org; Tue, 08 Jul 2008 16:43:53 -0400 From: Paul Brook Subject: Re: [Qemu-devel] RFC: ARM prologue linkage fix Date: Tue, 8 Jul 2008 21:43:46 +0100 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807082143.48545.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl On Tuesday 08 July 2008, Blue Swirl wrote: > Hi, > > I made a patch which allows sparc-linux-user target to be linked on an > ARM host. Is this OK? Sparc32 helloworld program runs successfully, > otherwise untested. In principle it looks ok, however: I think it deserves a comment in exec.c saying why we do this - the prologue is reached via a direct jump, so must be placed close to the code segment. Also, calling something .bss.code_gen, than placing it is .data is just asking for trouble :-) I suggest calling the section ".gen_code". We probably want the same thing on sparc and ppc hosts. I guess they can be added as required though. Paul