qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [RFC][PATCH] x86: Optional segment type and limit checks - v2
Date: Tue, 15 Jul 2008 17:12:40 +0100	[thread overview]
Message-ID: <20080715161240.GA32365@shareable.org> (raw)
In-Reply-To: <487CC6C7.3090408@siemens.com>

Jan Kiszka wrote:
> Don't want to stop all your creativity, but just like Paul I'm also a
> bit skeptical about the TLB way of achieving range and type safety.

Sure, that's understandable.  There has to be some "show me the code"
- I wish I had the time.  These are not simple optimisations, but they
could make segment checks free for most guests, so it's worth
considering them even if they're discarded.

> My major concern once was that the TLB works on a global scope so that
> you cannot tell the original segments behind some address apart.

Yes.  The only way around it is context - either having multiple TLBs,
or inlining segments into translated code, so you tell the original
segments apart at the call site.

> And extending the virtual address space for this is a no-go on
> 32-bit hosts (which I unfortunately had and still have to support
> here :->).

Definitely not increasing the virtual address space - I'm still using
32-bit hosts too :-)  I'm not sure that would be safe even on 64-bit
hosts - what if the guest has its own uses for the whole address
space?

Expanding the TLB key space (or equivalently, multiple TLBs) is
different from expanding the virtual address space, though.

-- Jamie

  reply	other threads:[~2008-07-15 16:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-09 12:12 [Qemu-devel] [RFC][PATCH] x86: Optional segment type and limit checks Jan Kiszka
2008-07-14 10:34 ` [Qemu-devel] [RFC][PATCH] x86: Optional segment type and limit checks - v2 Jan Kiszka
2008-07-14 10:55   ` Jamie Lokier
2008-07-14 11:11     ` Paul Brook
2008-07-14 14:02       ` Jamie Lokier
2008-07-14 17:50         ` Kevin O'Connor
2008-07-14 18:51           ` Jamie Lokier
2008-07-15 15:48             ` [Qemu-devel] " Jan Kiszka
2008-07-15 16:12               ` Jamie Lokier [this message]
2008-07-16  1:20               ` Kevin O'Connor
2008-07-16  2:43                 ` Kevin O'Connor
2008-07-14 11:05   ` [Qemu-devel] " Daniel P. Berrange
2008-07-15 15:43     ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080715161240.GA32365@shareable.org \
    --to=jamie@shareable.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).