From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KJGg5-00048S-U2 for qemu-devel@nongnu.org; Wed, 16 Jul 2008 19:44:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KJGg4-00046w-7k for qemu-devel@nongnu.org; Wed, 16 Jul 2008 19:44:57 -0400 Received: from [199.232.76.173] (port=58862 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KJGg4-00046k-3d for qemu-devel@nongnu.org; Wed, 16 Jul 2008 19:44:56 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:51970) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KJGg3-0006YA-L3 for qemu-devel@nongnu.org; Wed, 16 Jul 2008 19:44:55 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Various NICs: Fix suspend/resume of multiple instances Date: Thu, 17 Jul 2008 00:44:51 +0100 References: <487E2DCB.2090902@siemens.com> In-Reply-To: <487E2DCB.2090902@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807170044.52401.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka On Wednesday 16 July 2008, Jan Kiszka wrote: > We ran into the issue that restoring two (or more) instances of the same > NIC does not work. The reason is that the same instance number is passed > to register_savevm by many NIC emulations. Patch below addresses this > for eepro100, ne2000, pcnet and rtl8139 This is wrong. You should pass -1. Paul