From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] Save 3MB ioport table memory
Date: Wed, 23 Jul 2008 13:15:42 +0100 [thread overview]
Message-ID: <200807231315.43892.paul@codesourcery.com> (raw)
In-Reply-To: <20080723105821.GB4454@implementation.uk.xensource.com>
On Wednesday 23 July 2008, Samuel Thibault wrote:
> static void init_ioports(void)
> {
> - int i;
>...
> - }
> }
Why are you leaving empty functions?
> +static uint32_t default_ioport_readi(int index, uint32_t address)
While the abstraction is good, I don't like the name of this function.
I'd expect this to be a direct wrapper round default_ioport_read[bwl], not
something that calls the actual IO port handler. If your patch contains no
comments then everything must be intuitive and self-explanatory. Currently it
it not.
Paul
next prev parent reply other threads:[~2008-07-23 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 12:02 [Qemu-devel] [PATCH] Save 3MB ioport table memory Samuel Thibault
2008-07-23 1:52 ` Anthony Liguori
2008-07-23 10:58 ` Samuel Thibault
2008-07-23 12:15 ` Paul Brook [this message]
2008-07-23 12:39 ` Samuel Thibault
2008-07-23 15:21 ` Anthony Liguori
2008-07-23 15:50 ` Paul Brook
2008-07-23 16:11 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807231315.43892.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).