From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KLdG4-000571-1J
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:15:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KLdG2-00055F-B7
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:15:51 -0400
Received: from [199.232.76.173] (port=37012 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KLdG2-000557-4m
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:15:50 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:44200)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KLdG1-0002fv-Nn
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:15:50 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Save 3MB ioport table memory
Date: Wed, 23 Jul 2008 13:15:42 +0100
References: <20080721120211.GD4501@implementation.uk.xensource.com>
	<48868EDB.7010809@codemonkey.ws>
	<20080723105821.GB4454@implementation.uk.xensource.com>
In-Reply-To: <20080723105821.GB4454@implementation.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200807231315.43892.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@eu.citrix.com>

On Wednesday 23 July 2008, Samuel Thibault wrote:
> =A0static void init_ioports(void)
> =A0{
> - =A0 =A0int i;
>...
> - =A0 =A0}
> =A0}

Why are you leaving empty functions?

> +static uint32_t default_ioport_readi(int index, uint32_t address)

While the abstraction is good, I don't like the name of this function.
I'd expect this to be a direct wrapper round default_ioport_read[bwl], not=
=20
something that calls the actual IO port handler.  If your patch contains no=
=20
comments then everything must be intuitive and self-explanatory. Currently =
it=20
it not.

Paul