qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Luis Pureza <pureza@student.dei.uc.pt>
Subject: Re: [Qemu-devel] Weird behavior while using the instruction counter
Date: Thu, 24 Jul 2008 15:02:52 +0100	[thread overview]
Message-ID: <200807241502.53396.paul@codesourcery.com> (raw)
In-Reply-To: <3e1533500807240654x67920d8ao55c420390f421ee3@mail.gmail.com>

> > No. You're assuming the IO trap occurs on the last instruction, which not
> > true.  The problem is that cpu_exec_nocache introduces a second TB with
> > the same lookup key(pc+flags). cpu_io_recompile (and possibly other
> > places) assume the currently executing TB is the only tb that matches. It
> > needs to invalidate the original TB (if it exists) as well as the
> > uncached one.
>
> Obviously, you're right. I was testing with blocks of a single
> instruction. What do you think of this:
>
>  if (tb != &tbs[0] && (tb - 1)->pc == tb->pc) {
>         tb_phys_invalidate(tb - 1, -1);
>  }

No. There's no guarantee that the TBs are consecutive.

Paul

  reply	other threads:[~2008-07-24 14:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24 10:42 [Qemu-devel] Weird behavior while using the instruction counter Luis Pureza
2008-07-24 12:44 ` Paul Brook
2008-07-24 13:54   ` Luis Pureza
2008-07-24 14:02     ` Paul Brook [this message]
     [not found]       ` <3e1533500807240742u488272b7x12c4429cbfbb9297@mail.gmail.com>
2008-07-24 14:49         ` Fwd: " Luis Pureza
     [not found]         ` <200807241556.48810.paul@codesourcery.com>
2008-07-24 15:17           ` Luis Pureza
2008-07-24 16:02             ` Paul Brook
2008-07-24 17:58               ` Luis Pureza
2008-07-24 23:59                 ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807241502.53396.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=pureza@student.dei.uc.pt \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).