From: Gleb Natapov <gleb@qumranet.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Chris Lalancette <clalance@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/3]: vmware backdoor interface fix
Date: Mon, 28 Jul 2008 22:18:02 +0300 [thread overview]
Message-ID: <20080728191802.GF23771@minantech.com> (raw)
In-Reply-To: <488E16C8.4020708@codemonkey.ws>
On Mon, Jul 28, 2008 at 01:58:16PM -0500, Anthony Liguori wrote:
> Chris Lalancette wrote:
>> VMWare backdoor interface should work with IN/OUT port ops, but
>> currently only IN is supported. BOCHS bios uses OUT to query UUID.
>> The patch adds OUT support.
>>
>> Signed-off-by: Chris Lalancette <clalance@redhat.com>
>> Cc: Gleb Natapov <gleb@qumranet.com>
>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>>
>
> Applied. Thanks.
>
> I'm going to hold off on the rest of the series until we work out a
> better way to support -uuid. This is a pretty obvious fix though.
>
I don't get this logic. Either delete backdoor interface entirely, or
use is for something it was intended to be used for (uuid interface is
documented and proposed implementation is compatible with VMWare). Why
fix something you are not going to use?
--
Gleb.
next prev parent reply other threads:[~2008-07-28 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 13:25 [Qemu-devel] [PATCH 1/3]: vmware backdoor interface fix Chris Lalancette
2008-07-28 18:58 ` [Qemu-devel] " Anthony Liguori
2008-07-28 19:18 ` Gleb Natapov [this message]
2008-07-28 19:51 ` Anthony Liguori
2008-07-29 5:31 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728191802.GF23771@minantech.com \
--to=gleb@qumranet.com \
--cc=anthony@codemonkey.ws \
--cc=clalance@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).