From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KNYER-0000pg-EA
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:18:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KNYEP-0000ne-VF
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:18:07 -0400
Received: from [199.232.76.173] (port=47637 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KNYEP-0000na-QN
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:18:05 -0400
Received: from il.qumranet.com ([212.179.150.194]:52227)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@qumranet.com>) id 1KNYEP-00051t-DW
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:18:05 -0400
Date: Mon, 28 Jul 2008 22:18:02 +0300
From: Gleb Natapov <gleb@qumranet.com>
Message-ID: <20080728191802.GF23771@minantech.com>
References: <488DC8B8.3060500@redhat.com> <488E16C8.4020708@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <488E16C8.4020708@codemonkey.ws>
Subject: [Qemu-devel] Re: [PATCH 1/3]: vmware backdoor interface fix
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Chris Lalancette <clalance@redhat.com>, qemu-devel@nongnu.org

On Mon, Jul 28, 2008 at 01:58:16PM -0500, Anthony Liguori wrote:
> Chris Lalancette wrote:
>> VMWare backdoor interface should work with IN/OUT port ops, but
>> currently only IN is supported. BOCHS bios uses OUT to query UUID.
>> The patch adds OUT support.
>>
>> Signed-off-by: Chris Lalancette <clalance@redhat.com>
>> Cc: Gleb Natapov <gleb@qumranet.com>
>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>>   
>
> Applied.  Thanks.
>
> I'm going to hold off on the rest of the series until we work out a  
> better way to support -uuid.  This is a pretty obvious fix though.
>
I don't get this logic. Either delete backdoor interface entirely, or
use is for something it was intended to be used for (uuid interface is
documented and proposed implementation is compatible with VMWare). Why
fix something you are not going to use?

--
			Gleb.