From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNkI9-0005Aq-RJ for qemu-devel@nongnu.org; Tue, 29 Jul 2008 04:10:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNkI8-0005Ad-Dp for qemu-devel@nongnu.org; Tue, 29 Jul 2008 04:10:45 -0400 Received: from [199.232.76.173] (port=54875 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNkI8-0005Aa-78 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 04:10:44 -0400 Received: from mx1.redhat.com ([66.187.233.31]:50474) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNkI8-0007d8-38 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 04:10:44 -0400 Date: Tue, 29 Jul 2008 09:10:34 +0100 From: "Daniel P. Berrange" Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support Message-ID: <20080729081034.GG32498@redhat.com> References: <1217251078-6591-1-git-send-email-kraxel@redhat.com> <1217251078-6591-2-git-send-email-kraxel@redhat.com> <488DD206.8040404@codemonkey.ws> <488DDD2C.10308@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <488DDD2C.10308@redhat.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On Mon, Jul 28, 2008 at 04:52:28PM +0200, Gerd Hoffmann wrote: > >> +/* xen_machine.c */ > >> +extern QEMUMachine xenpv_machine; > >> +extern QEMUMachine xenfv_machine; > > > > Why does xenfv need its own machine type? > > This is how xen's qemu-dm handles it at the moment and I've decided to > do it the same way for simplicity. I think qemu could also figure it > using a hypercall. This is something I originally added to QEMU in Xen's tree. The basic idea is that the 'xenpv' macjine is a machine which /only/ provides the paravirtualized Xen backends drivers. The 'xenfv' machine type is just the same as the 'pc' machine type, but with the /addition/ of the Xen paravirtualized backends. Perhaps the latter could be thought of as more of a 'xenpc' (cf 'pc' and 'isapc') becasue its a variation on the regular PC machine type. Annoying that all the acronyms I come up with only differ by one letter :-) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|