From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNtmp-0000P8-6u for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:19:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNtmm-0000NK-Q6 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:19:02 -0400 Received: from [199.232.76.173] (port=52132 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNtmm-0000N9-GK for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:19:00 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:40750) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KNtml-0006vj-Q8 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:19:00 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Date: Tue, 29 Jul 2008 19:18:54 +0100 References: <488EBEFC.5040603@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807291918.55451.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org On Tuesday 29 July 2008, andrzej zaborowski wrote: > 2008/7/29 Chris Lalancette : > > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity > > in the save file, which matches what i2c_bus_load() expects to pull out > > of the save file later. Without this fix in place, KVM live migration > > fails since the sender is only sending 1 byte while the receiver is > > waiting to receive 4 bytes. > > Thanks, I committed this modified to use byte width afterall since the > addresses are 7-bit quantities. No they aren't. I2C also supports 10-bit addressing. Paul