From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] PATCH: Control over drive open modes for backing file
Date: Thu, 31 Jul 2008 14:46:55 +0100 [thread overview]
Message-ID: <200807311446.56381.paul@codesourcery.com> (raw)
In-Reply-To: <20080731133420.GD18548@redhat.com>
> +#define BDRV_O_RDONLY 0x0001 /* Force read-only */
> +#define BDRV_O_WRONLY 0x0002 /* Force writeable, no fallback */
> +#define BDRV_O_RDWR 0x0003 /* Try writeable, fallback to read-only
> */
This is IMHO really misleading. Normal O_* are not bitflags. The code uses
these as bitflags sometimes, which means your descriptions are contradictory.
Paul
next prev parent reply other threads:[~2008-07-31 13:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 11:31 [Qemu-devel] PATCH: Control over drive open modes for backing file Daniel P. Berrange
2008-07-31 12:15 ` Jamie Lokier
2008-07-31 13:08 ` Daniel P. Berrange
2008-07-31 13:34 ` Daniel P. Berrange
2008-07-31 13:46 ` Paul Brook [this message]
2008-07-31 13:55 ` Daniel P. Berrange
2008-07-31 15:05 ` Blue Swirl
2008-07-31 16:01 ` Jamie Lokier
2008-07-31 16:10 ` Daniel P. Berrange
2008-07-31 18:07 ` Blue Swirl
2008-07-31 14:58 ` Chris Wedgwood
2008-07-31 18:26 ` Anthony Liguori
2008-07-31 18:59 ` Jamie Lokier
2008-07-31 19:37 ` Anthony Liguori
2008-08-01 7:46 ` Jamie Lokier
2008-08-01 15:14 ` Anthony Liguori
2008-08-01 9:18 ` Daniel P. Berrange
2008-08-01 14:48 ` Anthony Liguori
2008-08-01 16:47 ` Ian Jackson
2008-08-01 17:09 ` Anthony Liguori
2008-08-01 17:10 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807311446.56381.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).