From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOYXP-0001pp-VW for qemu-devel@nongnu.org; Thu, 31 Jul 2008 09:49:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOYXM-0001lJ-VL for qemu-devel@nongnu.org; Thu, 31 Jul 2008 09:49:51 -0400 Received: from [199.232.76.173] (port=36000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOYXM-0001l8-RM for qemu-devel@nongnu.org; Thu, 31 Jul 2008 09:49:48 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:56592) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOYXM-000106-9V for qemu-devel@nongnu.org; Thu, 31 Jul 2008 09:49:48 -0400 From: Paul Brook Subject: Re: [Qemu-devel] PATCH: Control over drive open modes for backing file Date: Thu, 31 Jul 2008 14:46:55 +0100 References: <20080731113120.GJ23888@redhat.com> <20080731133420.GD18548@redhat.com> In-Reply-To: <20080731133420.GD18548@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200807311446.56381.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, "Daniel P. Berrange" > +#define BDRV_O_RDONLY =A0 =A0 =A00x0001 /* Force read-only */ > +#define BDRV_O_WRONLY =A0 =A0 =A00x0002 /* Force writeable, no fallback = */ > +#define BDRV_O_RDWR =A0 =A0 =A0 =A00x0003 /* Try writeable, fallback to = read-only > */ This is IMHO really misleading. Normal O_* are not bitflags. The code uses= =20 these as bitflags sometimes, which means your descriptions are contradictor= y. Paul