From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQgbg-00083P-AW
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 06:51:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQgbc-0007y8-Sb
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 06:51:03 -0400
Received: from [199.232.76.173] (port=50270 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQgO3-0005k3-12
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 06:36:59 -0400
Received: from smtp.eu.citrix.com ([62.200.22.115]:7777)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1KQgBF-0005VN-MP
	for qemu-devel@nongnu.org; Wed, 06 Aug 2008 06:23:45 -0400
Date: Wed, 6 Aug 2008 11:23:38 +0100
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu
Message-ID: <20080806102338.GA4448@implementation.uk.xensource.com>
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<48973F8E.8080109@codemonkey.ws>
	<20080805104630.GM4478@implementation.uk.xensource.com>
	<489835A3.6030804@redhat.com>
	<20080805112935.GO4478@implementation.uk.xensource.com>
	<48985336.2020709@redhat.com>
	<20080805150328.GT4478@implementation.uk.xensource.com>
	<20080805154140.GV4478@implementation.uk.xensource.com>
	<48997981.1030703@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <48997981.1030703@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org

Gerd Hoffmann, le Wed 06 Aug 2008 12:14:25 +0200, a écrit :
> The rough way to merge would look like this:
> 
>   - drop xen_console.[ch]
>   - drop xenfb.[ch]
>   - drop xen_machine_pv.c
> 
>   - add xen.h
>   - add xen-machine.c
>   - add xen-backend.[ch]
>   - add xen-console.c
>   - add xen-framebuffer.c
> 
>   - wind up stuff in the Makefiles.
>   - some global renames (domid -> xen_domid for example) as I took care
>     to prefix global xen variables & functions with xen_.
>   - probably some small fixups are needed ...

You forgot the _test_ stage.  You are basically asking us to replace our
well-tested implementation with your implementation, that's quite a
move.  You are not even providing a patch for us to check that nothing
has been left behind...

> Note that qemu-dm has a few optimizations in the qemu display code to
> avoid unneeded work.  I'd suggest to submit them upstream.

That's planned, yes.  But you too could do the same for the device
backend core for instance...

> The you can gradually move qemu-dm to be more upstream-ish while also
> updating xend accordingly.

That's what we are already doing in Ian's tree.

Samuel