From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A
Date: Thu, 7 Aug 2008 22:39:29 +0100 [thread overview]
Message-ID: <20080807213929.GD4507@implementation> (raw)
In-Reply-To: <489B6566.8040909@codemonkey.ws>
Anthony Liguori, le Thu 07 Aug 2008 16:13:10 -0500, a écrit :
> Samuel Thibault wrote:
> >Anthony Liguori, le Thu 07 Aug 2008 13:58:43 -0500, a écrit :
> >
> >>>@@ -21,6 +21,10 @@
> >>> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >>> DEALINGS IN
> >>> * THE SOFTWARE.
> >>> */
> >>>+
> >>>+#include <termios.h>
> >>>+#include <sys/ioctl.h>
> >>>
> >>>
> >>This doesn't look Windows friendly.
> >>
> >
> >How is qemu compiled on windows? Native with the windows headers?
> >That's quite different then indeed.
> >
>
> Yup, via mingw. But it doesn't seem termios or sys/ioctl are really
> being used in this file anyway?
Actually I checked the patch. I thought these includes were in vl.c.
These are at least used for TIOCM_*. I guess those should rather
receive a qemu abstracted name, and be converted to TIOCM_* in vl.c
Samuel
next prev parent reply other threads:[~2008-08-07 21:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 17:35 [Qemu-devel] [PATCH] upgrading emulated UART to 16550A Stefano Stabellini
2008-08-07 18:58 ` Anthony Liguori
2008-08-07 21:02 ` Samuel Thibault
2008-08-07 21:13 ` Anthony Liguori
2008-08-07 21:39 ` Samuel Thibault [this message]
2008-08-08 14:36 ` Stefano Stabellini
2008-08-07 19:26 ` Jason Wessel
-- strict thread matches above, loose matches on Subject: below --
2008-08-08 16:58 Stefano Stabellini
2008-08-09 18:26 ` Anthony Liguori
2008-08-09 18:44 ` Samuel Thibault
2008-08-11 14:17 ` Anthony Liguori
2008-08-08 14:55 Stefano Stabellini
2008-08-08 15:15 ` Stefano Stabellini
2008-08-05 13:15 Stefano Stabellini
2008-08-05 13:57 ` Thiemo Seufer
2008-08-05 14:17 ` Stefano Stabellini
2008-08-05 15:02 ` Jason Wessel
2008-08-05 15:15 ` Stefano Stabellini
2008-08-06 2:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807213929.GD4507@implementation \
--to=samuel.thibault@ens-lyon.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).