From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KRDCp-0006Lq-Pd
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 17:39:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KRDCo-0006JB-Eb
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 17:39:35 -0400
Received: from [199.232.76.173] (port=35433 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KRDCo-0006J6-71
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 17:39:34 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:30382)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <samuel.thibault@labri.fr>) id 1KRDCn-00059A-1s
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 17:39:33 -0400
Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com with ESMTP id
	<20080807213930.SKQS777.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Thu, 7 Aug 2008 22:39:30 +0100
Received: from implementation.famille.thibault.fr ([82.21.96.230])
	by aamtaout01-winn.ispmail.ntl.com with ESMTP id
	<20080807213930.LCWO5827.aamtaout01-winn.ispmail.ntl.com@implementation.famille.thibault.fr>
	for <qemu-devel@nongnu.org>; Thu, 7 Aug 2008 22:39:30 +0100
Received: from samy by implementation.famille.thibault.fr with local (Exim
	4.69) (envelope-from <samuel.thibault@labri.fr>) id 1KRDCj-0001TF-4m
	for qemu-devel@nongnu.org; Thu, 07 Aug 2008 23:39:29 +0200
Date: Thu, 7 Aug 2008 22:39:29 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A
Message-ID: <20080807213929.GD4507@implementation>
References: <489B3278.4080001@eu.citrix.com> <489B45E3.9040005@codemonkey.ws>
	<20080807210232.GA4507@implementation>
	<489B6566.8040909@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <489B6566.8040909@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori, le Thu 07 Aug 2008 16:13:10 -0500, a écrit :
> Samuel Thibault wrote:
> >Anthony Liguori, le Thu 07 Aug 2008 13:58:43 -0500, a écrit :
> >  
> >>>@@ -21,6 +21,10 @@
> >>> * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER 
> >>> DEALINGS IN
> >>> * THE SOFTWARE.
> >>> */
> >>>+
> >>>+#include <termios.h>
> >>>+#include <sys/ioctl.h>
> >>> 
> >>>      
> >>This doesn't look Windows friendly.
> >>    
> >
> >How is qemu compiled on windows?  Native with the windows headers?
> >That's quite different then indeed.
> >  
> 
> Yup, via mingw.  But it doesn't seem termios or sys/ioctl are really 
> being used in this file anyway?

Actually I checked the patch. I thought these includes were in vl.c.
These are at least used for TIOCM_*.  I guess those should rather
receive a qemu abstracted name, and be converted to TIOCM_* in vl.c

Samuel