From: "M. Warner Losh" <imp@bsdimp.com>
To: qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes
Date: Mon, 11 Aug 2008 07:32:55 -0600 (MDT) [thread overview]
Message-ID: <20080811.073255.1649768698.imp@bsdimp.com> (raw)
In-Reply-To: <20080811095457.GA4499@implementation.uk.xensource.com>
In message: <20080811095457.GA4499@implementation.uk.xensource.com>
Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
: Gerd Hoffmann, le Mon 11 Aug 2008 09:52:03 +0200, a écrit :
: > > The warning is generated because the definition of "handler" should
: > > also describe the parameters and not use the old () style. But in this
: > > case, they can vary:
: > > static void do_help(const char *name)
: > > static void do_quit(void)
: > [ ... ]
: >
: > > I don't have a good plan how to fix this, proposals are welcome.
: > > Changing all handlers to use va_args to just silence a gcc warning
: > > sounds like overkill.
: >
: > Using a union maybe?
:
: That should be the right thing yes.
Except it becomes unmanageable over time... It also doesn't enhance
type safety...
Warner
next prev parent reply other threads:[~2008-08-11 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 17:22 [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes Blue Swirl
2008-08-09 18:24 ` Anthony Liguori
2008-08-10 18:33 ` Blue Swirl
2008-08-11 7:52 ` Gerd Hoffmann
2008-08-11 9:54 ` Samuel Thibault
2008-08-11 13:32 ` M. Warner Losh [this message]
2008-08-11 13:30 ` M. Warner Losh
2008-08-11 14:21 ` Anthony Liguori
2008-08-11 14:48 ` Avi Kivity
2008-08-11 14:53 ` Paul Brook
2008-08-11 14:56 ` Laurent Vivier
2008-08-11 14:56 ` Anthony Liguori
2008-08-11 16:38 ` Avi Kivity
2008-08-11 16:47 ` Anthony Liguori
2008-08-11 18:52 ` Blue Swirl
2008-08-11 18:57 ` Laurent Vivier
2008-08-11 19:11 ` Blue Swirl
2008-08-11 19:22 ` Anthony Liguori
2008-08-11 20:03 ` Laurent Vivier
2008-08-12 1:57 ` Anthony Liguori
2008-08-12 8:14 ` Laurent Vivier
2008-08-12 9:22 ` Avi Kivity
2008-08-12 12:24 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811.073255.1649768698.imp@bsdimp.com \
--to=imp@bsdimp.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).